update-dmd-rewrite.sh: Deal with frontend headers having moved to compiler/include/#5124
Merged
kinke merged 1 commit intoldc-developers:masterfrom May 5, 2026
Merged
Conversation
…piler/include/ By leaving them as-is in our `dmd/` directory, so that the headers stay next to the D modules (locality is nice for e.g. frontend diffs), and our mods to the headers don't cause any conflicts.
Member
Author
|
Already used for the latest sync some mins ago (with manual dry-run tests beforehand obviously); headers are still there: https://github.com/ldc-developers/ldc/blob/dmd-rewrite-master/dmd/aggregate.h And the original commit (dlang/dmd@02c1d22) isn't in our history (empty remaining patch after git-rewrites). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By leaving them as-is in our
dmd/directory, so that the headers stay next to the D modules (locality is nice for e.g. frontend diffs), and our mods to the headers don't cause any conflicts.